Skip to content

Conversation

@JavierCladellas
Copy link
Collaborator

@JavierCladellas JavierCladellas commented Nov 13, 2024

Done:

  • Removed all reports that were stored under the git repository (reports/ and docs/pages/*)
  • Netlify will itself create the adoc reports under docs/modules/ROOT/pages for preview
  • Removed the generate_reports step of the CI, as we don't want any pushes.
  • On push to master, the GitHub runner in the CI will create the reports, antora will compile them under public/, and the deploy to gh pages will be handled as usual. No major changes...

@JavierCladellas JavierCladellas added enhancement A new feature or request github_actions Pull requests that update GitHub Actions code labels Nov 13, 2024
@JavierCladellas JavierCladellas self-assigned this Nov 13, 2024
@JavierCladellas JavierCladellas linked an issue Nov 13, 2024 that may be closed by this pull request
2 tasks
@netlify
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit 72d7171
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/6749c237de4229000817dfc1
😎 Deploy Preview https://deploy-preview-119--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas
Copy link
Collaborator Author

@prudhomm Is it possible to add the girder api key to Netlify's environment ?

@prudhomm
Copy link
Member

Oops yes, i can add env variable. I will do that when i come back

@JavierCladellas
Copy link
Collaborator Author

Oops yes, i can add env variable. I will do that when i come back

@prudhomm Small reminder (not urgent) to add the GIRDER_API_KEY variable in netlify's environment. Thank you !

@prudhomm
Copy link
Member

@JavierCladellas there are conflicts here. GIRDER_API_KEY has now been defined

@JavierCladellas JavierCladellas marked this pull request as ready for review November 25, 2024 09:36
@JavierCladellas
Copy link
Collaborator Author

@JavierCladellas there are conflicts here. GIRDER_API_KEY has now been defined

Everything seems to be working as expected! Netlify renders the files by itself.
The .adoc files and the reframe reports are no longer stored in the GitHub repo.
@prudhomm @vincentchabannes

@vincentchabannes vincentchabannes merged commit 0256b81 into master Nov 29, 2024
5 of 6 checks passed
@vincentchabannes vincentchabannes deleted the 101-do-not-store-adoc-files-in-git-tree branch November 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A new feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not store adoc files in git tree

4 participants