-
Notifications
You must be signed in to change notification settings - Fork 2
resolves: 126 handle custom website generation #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves: 126 handle custom website generation #148
Conversation
✅ Deploy Preview for benchmarking-polite-crostata-92f389 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@JavierCladellas I need more context with respect to the workflow here. when is this done ? initially ? at each benchmarking, ? |
|
would you have a graphics explaining the workflow ? |
At each benchmark, a I have started a sequence diagram in here: https://www.figma.com/board/Icw2MOg9W5iGxRaVvXfk3a/benchmark-code-design?node-id=0-1&node-type=canvas&t=uBcKWX7Skt1T4XDw-0
|

As of #119 , the docs/modules/ROOT/ pages/ should be almost empty (will contain index.html), the pages generation will be completely handled by GitHub runners.
I propose that users generate their own websites under the same ROOT module (there should be no conflicts).
For this: (there is a --website flag that automates this process)
execute-benchmark --machine-config ... --benchmark-config ... --plots-config ...Outputs will be stored depending on the specified on the machine config, otherwise, they can use the--move-resultsoption.This script will generate a webiste_config.json file containing the executed benchmark hierarchy (will be updated if more benchmarks are executed ) . This file can be later on customised if needed (add descriptions, variables to show, etc.)
./reports/render-benchmarks --config_file ./reports/website_config.json --modules_path ./docs/modules/ROOT/pagesnpm run antoranpm run start@vincentchabannes @prudhomm Any suggestions for how users should be able to generate and visualise their own benchmarking website ?