fix: surface internal API stream errors - #2212
Merged
felladrin merged 1 commit intoJul 24, 2026
Merged
Conversation
felladrin
approved these changes
Jul 24, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2176.
When the
/inferenceproxy exhausts its models, it sends an SSE frame with anerrorfield and nochoices. The client previously dereferencedchoices[0]for every parsed frame, replacing the useful server message with aTypeError.This change:
ChatGenerationErrorwith the server-provided message for stringerror frames;
The normal content path is unchanged. Chunk-boundary buffering tracked in
#2177 remains outside this patch.
Type of Change
Checklist
npm run lintpassesnpm run test), with tests added where it made senseSecurity, performance, or breaking changes? Expand if relevant.
None. The patch changes only client-side handling of an existing server error
frame and adds no new API, dependency, or migration requirement.