Credit ONNX Runtime for reranking in the acknowledgments - #2241
Merged
Conversation
Reranking moved to ONNX Runtime in #2235, but the acknowledgments table still credited llama.cpp for it. llama.cpp keeps its row, since wllama is llama.cpp compiled to WebAssembly and still powers in-browser inference. Only the reranking half of that row's role moves out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Credits ONNX Runtime for reranking in the acknowledgments table. Reranking moved off llama.cpp in #2235, but the table still credited it for that role.
llama.cpp keeps its row: wllama is llama.cpp compiled to WebAssembly and still powers in-browser inference, so only the reranking half of that row's role moves out.
Before:
After:
The new row sits directly after SearXNG, so the table follows the pipeline: aggregate the results, rerank them, then generate the answer.
Nothing else in the README needed changing. The architecture diagram already says
Reranker / ONNX Runtime, and the prose describes reranking without naming an engine ("reranked locally by a cross-encoder model"). The llama.cpp mention further up is about pointing MiniSearch at a llama.cpp server as an OpenAI-compatible backend, which is unrelated.Type of Change
How to test
npm run lintpasses, includingscripts/documentation-validator.cjs, which checks every link inREADME.md.https://github.com/microsoft/onnxruntimereturns HTTP 200.Checklist
npm run lintpassesnpm run test), with tests added where it made senseNo tests: the change is one table row in the README.
Security, performance, or breaking changes
None.