While consolidating the auth event list for fells-code/seamless-auth-types#4, the api's AUTH_EVENT_TYPES and the admin dashboard's hand-copied version had drifted apart. Reconciling them turned up two dead entries (bootstrap_admin_check_skipped and bootstrap_admin_granted, for functionality that has since been removed), which suggests the list is not pruned when features go away.
magic_link_failed is the one to check first: it is in this repo's list but was absent from the dashboard's copy, which is the same signature the dead bootstrap entries had.
Worth doing a pass over the whole list and, for each entry, confirming there is still a call site that emits it. A test that asserts every member of AUTH_EVENT_TYPES is referenced somewhere in src/ would keep it from drifting again, and would have caught the bootstrap entries when that code was removed.
The consolidated list in @seamless-auth/types currently has 74 entries, with the bootstrap_admin_* pair already removed.
While consolidating the auth event list for fells-code/seamless-auth-types#4, the api's
AUTH_EVENT_TYPESand the admin dashboard's hand-copied version had drifted apart. Reconciling them turned up two dead entries (bootstrap_admin_check_skippedandbootstrap_admin_granted, for functionality that has since been removed), which suggests the list is not pruned when features go away.magic_link_failedis the one to check first: it is in this repo's list but was absent from the dashboard's copy, which is the same signature the dead bootstrap entries had.Worth doing a pass over the whole list and, for each entry, confirming there is still a call site that emits it. A test that asserts every member of
AUTH_EVENT_TYPESis referenced somewhere insrc/would keep it from drifting again, and would have caught the bootstrap entries when that code was removed.The consolidated list in
@seamless-auth/typescurrently has 74 entries, with thebootstrap_admin_*pair already removed.