chore(admin): remove stale session-DTO TODO#73
Merged
Conversation
The shared session serializer (serializeSession) and public response schema (SessionListResponseSchema / SessionSchema) already exist and are used by getUserDetail, listUserSessions, and listAllSessions, and the routes validate responses against them. Remove the now-inaccurate TODO. Closes #16
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Summary
#16 asked for a reusable public session DTO for the admin APIs (session shaping was duplicated with a TODO). That refactor is already in place:
serializeSession(src/services/apiResponseSerializers.ts) is the shared mapper, used bygetUserDetail,listUserSessions, andlistAllSessions.SessionSchema/SessionListResponseSchema(src/schemas/session.responses.ts), and the admin session routes declare it as their200response, so responses are validated.The only remnant was a stale
// TODO: Need a public session return type for sessionscomment abovelistUserSessions. This removes it. No behavior change.Testing
Lint + typecheck clean.