fix(verify): follow the React SDK past its passkey naming step - #168
Merged
Conversation
@seamless-auth/react used to open a "Name This Device" modal after "Register Passkey" was pressed, and registerWithPasskey typed into it before the WebAuthn ceremony would start. That view is gone from the SDK, so the helper waited 30 seconds for a placeholder that no longer renders and then timed out, failing react/passkeyRegister.spec.ts and react/passkeyLogin.spec.ts (which registers before it signs back in). The helper now stops at the button, which is where the ceremony begins. This tracks the SDK release that drops the modal. A --local run against an older React checkout, or a published run before that release lands on npm, will fail on the modal this no longer dismisses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the two lines in
registerWithPasskey(verify/harness/lib/reactFlows.ts) that filled the SDK's "Name This Device" modal and clicked Continue. The helper now stops at the Register Passkey click, which is where the WebAuthn ceremony begins.Why
@seamless-auth/reactremoved that modal in fells-code/seamless-auth-react#140. The harness kept typing into it, so the helper waited 30 seconds for a placeholder that no longer renders and then timed out:That took down two react specs:
react/passkeyRegister.spec.tsandreact/passkeyLogin.spec.ts, which registers before it signs back in. Only the shared helper needed changing; neither spec references the modal directly.Release ordering
verify-conformance.ymldefaults tolocal: true, building the React SDK frommain, so this fix is what makes PR and cross-repo runs green again.released-smoke.ymlruns nightly withlocal: falseagainst published npm, where@seamless-auth/reactis still0.9.0with the modal. That run will fail on the modal this no longer dismisses until the SDK release ships (fells-code/seamless-auth-react#134, the open Version Packages PR). Called out in the changeset.Checks
cd verify/harness && npx tsc --noEmitclean,npm run buildclean,npm test816 passed.A local
seamless verify --local --filter=loginwas attempted but aborted on a host port conflict (Bind for 127.0.0.1:5312 failed: port is already allocated) unrelated to this change, so the end-to-end pass is left to this PR's conformance job.