EMRY-003 registry + EMRY-002 review fixes (recover dropped stacked merge) - #51
Merged
Conversation
…ack contract - Pin the 'type' tag string of every Event variant against rename drift - Document on Event: msgpack needs with_struct_map; JSON encodes NaN/Inf as null (lossy) so non-finite values must be caught and surfaced via Alert - Fix MetricId doc capacity 65 535 -> 65 536
Add MetricRegistry mapping names to dense u16 MetricIds for the hot path. Idempotent register(), try_register() for the full-table case, name()/get() resolution, and MAX_METRICS = 65536 cap. Stable-id and duplicate-name tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers two already-reviewed commits that did not reach
main: PR #49 was merged at its original commit before the EMRY-002 review fixes were pushed, and PR #50 (registry) merged into #49's branch rather thanmain. This brings both ontomain.Contains:
Eventtype tag, documented the msgpackwith_struct_map+ lossy-NaN-as-null contract, fixed capacity doc.MetricRegistryintern table incrates/emry-core/src/registry.rs.Gate green: fmt, clippy
-D warnings, 21 tests, registry 100% line coverage.Going forward: branch each issue off
mainand merge sequentially (no stacking) to avoid this.