EMRY-016: Run metadata files (run.meta, config.json, summary.json) - #61
Merged
Conversation
emry-store::meta adds the run-directory layout: RunMetaFile + Summary structs,
run_dir_name/create_run_dir for logs/{project}_{timestamp}/, and a
dependency-free UTC epoch->YYYYMMDD_HHMMSS formatter (Hinnant civil_from_days).
Engine::start writes run.meta (v4 run_id, start_time, mode) + config.json;
finish writes summary.json (duration, reason, steps, dropped). RunConfig gains
a mode field. Demo now emits the full five-file layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes EMRY-016 (#14). Branched off
main. Completes M1.What
emry-store/src/meta.rs:RunMetaFile+Summarystructs;run_dir_name/create_run_dirfor thelogs/{project}_{timestamp}/layout;write_jsonhelper.YYYYMMDD_HHMMSSformatter (Hinnantcivil_from_days) — avoids pulling in a date crate.emry-engine/src/session.rs:Engine::startwritesrun.meta(v4 run_id, start_time, mode) +config.json;finishwritessummary.json(duration, reason, steps, dropped).RunConfiggains amodefield.Verification
./scripts/pre-commit-rust.shgreen: clippy-D warnings, 43 engine + 17 store tests, meta.rs 100% / session.rs 96% lines, total 97.99%run.meta(v4 uuid + "file" mode) andsummary.json(200 steps, COMPLETED) contents.19700101_000000) and a known 2021 value.Review
A focused review verified the
civil_from_daystranscription against Hinnant's reference (era/day-of-era/month/day math, negative-z truncation, constants) — correct. Two 'important' findings examined and declined as non-bugs (.and()error priority is intentional; thecreate_run_dirclock-fallback concern is pre-existing and unused by the engine).