-
Notifications
You must be signed in to change notification settings - Fork 0
Revert "Clarify EPI history comment" #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fermga
merged 1 commit into
main
from
revert-3-codex/update-comment-for-_epi_hist-preparation
Aug 27, 2025
Merged
Revert "Clarify EPI history comment" #10
fermga
merged 1 commit into
main
from
revert-3-codex/update-comment-for-_epi_hist-preparation
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for stunning-zabaione-f1f1ef failed. Why did it fail? →
|
fermga
added a commit
that referenced
this pull request
Oct 19, 2025
Operators involved: [Coherencia|Resonancia|Recursividad] Affected invariants: [#1, #4, #8, #9, #10] Key changes: - Documented TNFR architecture overview and invariant enforcement map in README - Added architecture conventions and references for contributors Expected risks/dissonances: Low; documentation alignment only Metrics: Documentation-only change (no runtime metrics) Equivalence map: N/A
fermga
added a commit
that referenced
this pull request
Oct 23, 2025
Operators involved: [Emission, Reception, Coherence, Resonance, Silence, Self-organization, Transition] Affected invariants: [#9, #10] Key changes: - Delete tests/legacy_tokens.py and stop exposing it through tests package. - Inline English-only placeholder identifiers across CLI, public API, metrics, alias, and structural tests. - Update remesh and node alias tests to use new deprecated tokens and maintain rejection assertions. Expected risks/dissonances: Low risk; changes confined to tests verifying legacy token rejection. Metrics: pytest -o addopts='' tests/integration/test_cli.py tests/integration/test_public_api.py tests/unit/dynamics/test_operator_names.py tests/unit/metrics/test_diagnosis_state.py tests/unit/metrics/test_si_helpers.py tests/unit/alias/test_theta_compat.py tests/unit/config/test_presets.py tests/unit/structural/test_node_aliases.py tests/unit/structural/test_remesh.py && pytest -o addopts='' tests/unit/structural/test_structural.py tests/unit/structural/test_observers.py Equivalence map: Replaced shared legacy token imports with local DEPRECATED_* constants.
This was referenced Nov 2, 2025
This was referenced Nov 5, 2025
8 tasks
fermga
pushed a commit
that referenced
this pull request
Nov 11, 2025
…mework Operators involved: Coherence (IL), Self-organization (THOL) Affected invariants: #9 (structural metrics), #10 (domain neutrality) Key changes: - Promoted Φ_s to CANONICAL status with 2,400+ experiments validation - Added comprehensive TNFR_FORCES_EMERGENCE.md documenting phase fields research - Documented research fields (|∇φ|, K_φ, ξ_C) with promotion criteria - Consolidated grammar documentation structure - Enhanced AGENTS.md with structural fields section - Added U6 experimental results and analysis tools - Implemented physics fields module (fields.py, liouville.py) - Added cross-domain validation framework Expected risks/dissonances: None - documentation strengthens theoretical coherence Metrics: Documentation C(t) ↑ (increased consistency and traceability) Phase tracking: Research fields remain phase-compatible (Invariant #5 preserved) Structural potential: corr(Δ Φ_s, ΔC) = -0.822 validates canonical promotion Research fields: |corr| < 0.15 (below threshold), remain RESEARCH status
19 tasks
This was referenced Nov 11, 2025
13 tasks
fermga
pushed a commit
that referenced
this pull request
Nov 11, 2025
…storing structural integrity) Operators involved: Coherence (IL) - Stabilizes module structure through negative feedback Affected invariants: - #4 (Operator Closure): Preserved API compatibility via re-exports - #8 (Controlled Determinism): Deterministic import resolution - #10 (Domain Neutrality): No domain-specific assumptions introduced Key changes: - Created src/tnfr/validation/base.py: Isolated ValidationOutcome, Validator, SubjectT - Updated src/tnfr/validation/runtime.py: Import from .base instead of . - Updated src/tnfr/validation/__init__.py: Re-export from .base (removed duplicates) - Updated src/tnfr/validation/spectral.py: Import from .base - Added test_circular_import_fix.py: Verification test for complete import chain Expected risks/dissonances: None - structure strengthened, API preserved Metrics: - C(t): ↑ (module structure now coherent) - ΔNFR: ↓ (circular dependency eliminated) - Si: ↑ (stable import resolution) Equivalence map: - ValidationOutcome: validation.__init__ → validation.base → validation.__init__ (re-exported) - Validator: validation.__init__ → validation.base → validation.__init__ (re-exported) - API surface unchanged for external consumers Fixes #2926 circular import blocking CI/CD
19 tasks
13 tasks
19 tasks
13 tasks
19 tasks
13 tasks
19 tasks
13 tasks
19 tasks
13 tasks
fermga
pushed a commit
that referenced
this pull request
Nov 14, 2025
Intent: Improve maintainability by dividing large 2,146-line metrics module Operators involved: Code organization (no runtime operators affected) Affected invariants: #10 (Domain Neutrality - modular organization) Key changes: - Split src/tnfr/operators/metrics.py (2,146 lines) into 5 modules: * metrics_core.py: Shared utilities and helpers (89 lines) * metrics_basic.py: emission, reception, coherence, dissonance (500 lines) * metrics_network.py: coupling, resonance, silence + 4 helpers (693 lines) * metrics_structural.py: expansion, contraction, self_organization, mutation, transition, recursivity + helper (1,089 lines) * metrics.py: Facade for backward compatibility (61 lines) - Created scripts/split_metrics.py for automated refactoring - Preserved all public APIs (100% backward compatible) - Exported private helpers (_compute_*, _detect_*) for test compatibility Module organization: - Core: get_node_attr() + alias system + constants - Basic: Single-node structural operators (4 functions) - Network: Multi-node coupling/propagation operators (3 functions + 4 helpers) - Structural: Complex transformation operators (6 functions + 1 helper) - Facade: Re-exports all + U6 experimental telemetry Testing validation: - test_operator_enhancements.py: 23/23 passed ✅ - test_sha_extended_metrics.py: 33/33 passed ✅ - test_thol_metrics.py: Passed ✅ - test_nul_densification.py: Passed ✅ - test_mutation_metrics_comprehensive.py: Passed ✅ - Total: 99+ tests verified Benefits: - Improved navigation: Find operator metrics by category - Reduced cognitive load: ~400-700 lines per module vs 2,146 - Better testability: Can test modules independently - Clearer dependencies: Explicit imports between modules - Maintainability: Changes isolated to relevant module Expected risks/dissonances: None - all tests passing, APIs preserved Metrics before/after: - Src files: 255 → 259 (+4 new modules, 1 facade) - Test files: 492 (unchanged) - Health: 100/100 → 100/100 (maintained) ✅ - Imports: All backward compatible - Line distribution: 2,146 → 89+500+693+1,089+61 = 2,432 total (includes docstrings, __all__, imports in each module) Backup files: - metrics.py.backup: Pre-split copy - metrics.py.old: Renamed original after split TNFR Canonicity: Strengthens Invariant #10 (modular organization) without changing structural behavior. Task completion: Phase 1, Task 4 (4h, medium risk) ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.