Fix phase sync observer math import and add history test #7

fermga · 2025-08-27T18:31:51Z

Summary

import math at module level for sincronía_fase
add regression test verifying phase_sync and kuramoto_R history metrics

Testing

pytest -q

https://chatgpt.com/codex/tasks/task_e_68af49ab24c48321a278ded5ed44d50d

Move math import to module level and remove delayed import inside sincronía_fase. Add regression test ensuring phase_sync and kuramoto_R metrics are recorded in history.

netlify · 2025-08-27T18:31:56Z

❌ Deploy Preview for stunning-zabaione-f1f1ef failed. Why did it fail? →

Name	Link
🔨 Latest commit	`6965713`
🔍 Latest deploy log	https://app.netlify.com/projects/stunning-zabaione-f1f1ef/deploys/68af4f19145fc40008bfadad

…rencias Operadores implicados: [Autoorganización] Invariantes afectados: [#7] Cambios clave: importar ensure_node_offset_map; consultar mapa en offset; prueba del offset no nulo Riesgos/disonancias previstas: fallo si el grafo no expone offset map; mitigado con valor por defecto 0 Métricas: C(t) estable; Si sin cambio; νf sin cambio; fase sin cambio Pruebas: test_offset_non_zero_with_mapping Mapa de equivalencias: N/A

Intent: clarify graph entry validation\nOperators involved: [Self-organization]\nAffected invariants: [#7]\nKey changes:\n- refine internal helper docstring\nExpected risks/dissonances: none\nMetrics: C(t) stable, phase neutral, nu_f unchanged\nEquivalence map: none

…lf-organization]\nAffected invariants: [#7, #9]\nKey changes:\n- Centralized node attribute aliases into single dictionary\n- Added get_aliases helper and updated modules/tests\n- Revised dynamic tests and cache handling\nExpected risks/dissonances:\n- Vectorized DNFR deviations marked xfail\nMetrics: C(t) stable; Si, νf, phase unchanged\nEquivalence map:\n- ALIAS_VF -> get_aliases('VF')\n- ALIAS_THETA -> get_aliases('THETA')\n

Operators involved: [Self-organization, Transition] Affected invariants: [#4, #7] Key changes: - Extraer caché de jitter y utilidades a submódulo dedicado - Mover funciones de remallado a nuevo submódulo - Simplificar operators.__init__ y reexportar API Expected risks/dissonances: posibles errores de importación; mitigados con reexportes y pruebas Metrics: C(t), Si sin cambios; νf y phase estabilizadas Equivalence map: tnfr.operators.* -> tnfr.operators.remesh/jitter

Operators involved: [Coherence, Self-organization] Affected invariants: [#1, #7] Key changes: - expose kahan_sum at module scope - scan weights once for negatives and totals - lazy helper exports to break circular imports Expected risks/dissonances: import indirection may hide missing symbols; mitigated via __getattr__ guard Metrics: C(t), Si, νf, phase unchanged Equivalence map: None

Intent: centralize node helpers\nOperators involved: [Self-organization]\nAffected invariants: [#7]\nKey changes:\n- introduce NodeBase mixin with common push_glyph/offset/all_nodes\n- derive NodoTNFR and NodoNX from NodeBase\n- cover NodoNX offset in tests\nExpected risks/dissonances: minimal; exercised via existing test suite\nMetrics: C(t), Si stable; vf and phase unchanged\nEquivalence map: n/a

Operators involved: [Self-organization] Affected invariants: [#5, #7] Key changes: - expose accumulate_cos_sin for phase math reuse - reuse helper in neighbor_phase_mean_list and legacy wrapper - export helper via helpers package and add regression test Expected risks/dissonances: minimal, covered by tests Metrics: C(t) stable; phase handling unchanged Equivalence map: _accumulate_cos_sin -> accumulate_cos_sin

Operators involved: [Self-organization] Affected invariants: [#7] Key changes: - Introduce _ensure_history for validation and deque creation - Redirect push_glyph, recent_glyph, ensure_history to helper - Drop ensure_history_deque and _validated_history - Adjust tests for new API Expected risks/dissonances: unified logic might mis-handle zero-window cases; covered by tests Metrics: C(t), Si, νf, phase unchanged Equivalence map: ensure_history_deque/_validated_history -> _ensure_history

Intent: streamline sense index weight caching for coherent reuse Operators involved: [Self-organization] Affected invariants: [#7, #8] Key changes: - factor config-key creation and cache updates into _cache_weights - rely on edge_version_cache with unique ("_Si_weights", cfg_key) entries - clarify caching responsibilities in docs and drop unused import Expected risks/dissonances: cache desync if edge version diverges; mitigated by edge_version_cache keying Metrics: expect unchanged C(t), Si, νf and phase behaviour Equivalence map: N/A

Intent: unify callback normalization and streamline registry Operators involved: [Self-organization, Transition] Affected invariants: [#7] Key changes: - merge callback normalization utilities into _normalize_callbacks - simplify registry validation via _validate_registry - adjust callbacks usage and tests Expected risks/dissonances: potential mis-normalization if inputs deviate from expectations Metrics: C(t), Si, νf, phase unaffected Equivalence map: _normalized_callbacks/_normalize_callback_registry -> _normalize_callbacks

Intent: clarify THOL evaluation to preserve structural coherence Operators involved: [Self-organization, Recursivity] Affected invariants: [#7] Key changes: - Introduced THOLEvaluator generator class handling nested THOL frames and closures - Delegated _flatten_thol to THOLEvaluator and updated _flatten to use the new iterator - Revised program tests to validate THOLEvaluator iteration and limits Expected risks/dissonances: possible misalignment in THOL closure propagation; mitigated with unit tests for repeats and body limits Metrics: C(t) stable; no change in νf, phase or Si anticipated Equivalence map: THOLEvaluator (new iterable) replaces direct _flatten_thol expansion

Operators involved: [Self-organization] Affected invariants: [#7] Key changes: - replace bespoke _flatten_tokens with flatten_structure - simplify CLI exports and tests Expected risks/dissonances: minimal; flatten_structure validated by existing tests Metrics: C(t), Si, νf unchanged Equivalence map: _flatten_tokens -> flatten_structure

Operators involved: [Mutation] Affected invariants: [#7] Key changes: - Materialize callback entries as tuples before length checks - Return None on TypeError during normalization - Add tests for list and generator entries Expected risks/dissonances: generators consumed during materialization Metrics: C(t) stable; Si unaffected; νf invariant; phase unchanged Equivalence map: none

Intent: improve module encapsulation Operators involved: [Transition, Recursivity] Affected invariants: [#7] Key changes: - expose stable_json and cached_node_list wrappers while keeping helper internals private - update consumers and tests to use new public wrappers - drop internal helper names from __all__ Expected risks/dissonances: minimal risk of downstream import breaks, mitigated by test suite Metrics: C(t), Si, νf, phase unchanged Equivalence map: _stable_json->stable_json, _cache_node_list->cached_node_list

Intent: improve NodoNX attribute coherence for clearer static typing Operators involved: [Self-organization] Affected invariants: [#7] Key changes: - declare NodoNX attribute properties statically - remove dynamic setattr loop - adjust attribute spec comment Expected risks/dissonances: minimal risk of missing attributes, mitigated by existing tests Metrics: C(t), Si, νf, phase expected unchanged Equivalence map: n/a

Operators involved: [Coherence, Observation, Self-organization] Affected invariants: [#7] Key changes: - extract glyph timing helpers to new module - move coherence/observer updates to dedicated module - relocate reporting functions and update import shims Expected risks/dissonances: minimal, relying on re-exports for backwards compatibility Metrics: N/A Equivalence map: tnfr.metrics.core API maintained via shims

Operators involved: [Self-organization, Coupling] Affected invariants: [#7, #8] Key changes: - document legacy cache shim - annotate edge cache for test monkeypatching Expected risks/dissonances: legacy shim may persist; marked for removal Metrics: (C(t), Si, νf, phase) unchanged Equivalence map: tnfr.helpers.cache -> tnfr.helpers.node_cache & tnfr.helpers.edge_cache

Operators involved: [Self-organization] Affected invariants: [#7] Key changes: - replace heap-based counter with Counter.most_common - simplify pop_least_used and batch trimming - refresh tests and performance checks Expected risks/dissonances: possible eviction order shifts; covered by tests Metrics: C(t), Si, νf, phase unchanged Equivalence map: None

Intent: reduce duplication in THOLEvaluator recursion Operators involved: [Self-organization, Recursivity] Affected invariants: [#7] Key changes: - add _push_thol_frame helper to validate and queue THOL blocks - reuse helper in THOLEvaluator.__init__ and __next__ - test recursive expansion and bad parameters Expected risks/dissonances: minimal; ensures THOL semantics preserved Metrics: none Equivalence map: none

Operators involved: [Reception, Expansion] Affected invariants: [#7] Key changes: - make _parse_tokens yield validated tokens lazily - update callers and add lazy & large-input tests Expected risks/dissonances: deferred validation raises late; covered by tests Metrics: n/a Equivalence map: n/a

…tion]\nAffected invariants: [#7]\nKey changes:\n- replace intermediate list with generator in _iter_node_digests\nExpected risks/dissonances: none; behavior remains deterministic\nMetrics: (C(t), Si, νf, phase) unchanged\nEquivalence map: none

Intent: clarify backward-compatible logger alias Operators involved: [Coherence, Transition] Affected invariants: [#7, #8] Key changes: - document get_module_logger alias in logging_utils Expected risks/dissonances: alias may conceal outdated imports Metrics: C(t) unchanged; uniform logging behaviour Equivalence map: get_module_logger -> get_logger

Operators involved: [Self-organization, Recursivity] Affected invariants: [#7] Key changes: - Remove obsolete _flatten_thol helper - Rename tests to validate THOLEvaluator directly Expected risks/dissonances: Minimal; internal helper removal contained by existing tests Metrics: C(t), Si, νf, phase unchanged Equivalence map: _flatten_thol -> THOLEvaluator

Intent: streamline coherence metric tracking Operators involved: [Coherence, Self-organization] Affected invariants: [#4, #7] Key changes: - move _update_coherence and related helpers into metrics/coherence - drop obsolete metrics/coherence_updates.py and redirect imports - update metrics/__init__ and core to use new locations Expected risks/dissonances: possible metric omissions contained by full test suite Metrics: C(t), Si, νf, phase expected unchanged Equivalence map: _update_* functions now exported from metrics.coherence

Intent: consolidate token parsing map into shared module Operators involved: [Transition, Recursivity] Affected invariants: [#4, #7] Key changes: - Introduce shared TOKEN_MAP and THOL parser module - Add equivalence test between core and CLI parsers Expected risks/dissonances: shared map mutations require caution Metrics: (C(t), Si, νf, phase) stable Equivalence map: TOKEN_MAP -> tnfr.token_map.TOKEN_MAP

Operators involved: [Mutation|Transition|Recursivity] Affected invariants: [#4, #7] Key changes: - remove tnfr.operators grammar getattr shim and stub exports - retarget code/tests/docs to tnfr.validation grammar helpers - refresh validation docs to highlight unified namespace Expected risks/dissonances: minimal risk of stale imports; validated via targeted grammar tests Metrics: unchanged (validation surface only) Equivalence map: tnfr.operators.<grammar helper> -> tnfr.validation.<same>

Operators involved: [Coherence, Recursivity] Affected invariants: [#7] Key changes: - Extend ensure_collection with iterator views and update the public stub - Refactor flatten._iter_source to rely on the shared helper - Add tests covering iterator views and parse token edge cases Expected risks/dissonances: Minimal regression risk; exercised targeted tests Metrics: C(t) stable, νf unchanged Equivalence map: None

- Add __getstate__/__setstate__ methods to BEPIElement for pickle optimization - Implement serialize_bepi_json() and deserialize_bepi_json() helpers - Complex numbers converted to {"real", "imag"} dicts for JSON compatibility - Add comprehensive tests for pickle, JSON, YAML serialization - Verify nested EPI handling preserves operational fractality (invariant #7) - All roundtrips preserve structural integrity (invariant #1) Co-authored-by: fermga <203334638+fermga@users.noreply.github.com>

Operators involved: [Coherence, Resonance] Affected invariants: [#7, #9] Key changes: - Documented GraphLike expectations in cache, structural and operator modules - Expanded GraphLike protocol to include NetworkX-style views and adjacency access - Normalised CLI graph traversal helpers and added GraphLike regression tests Expected risks/dissonances: Low; broader protocol could surface unsupported wrappers Metrics: C(t) stable; Si unchanged; νf unaffected; phase unaffected Equivalence map: GraphLike.nodes→NodeView, GraphLike.edges→EdgeView, GraphLike.__getitem__→adjacency mapping

Intent: Add U5 canonical grammar constraint for multi-scale coherence preservation Operators involved: REMESH (Recursivity), IL (Coherence), THOL (Self-organization) Affected invariants: #7 (Operational Fractality), #2 (Structural Units) Key changes: - Added RECURSIVE_GENERATORS and SCALE_STABILIZERS operator sets - Implemented validate_multiscale_coherence() in GrammarValidator - Added depth parameter to Recursivity operator (default=1) - Updated unified_grammar.py facade to export U5 sets - Integrated U5 validation into grammar pipeline Physical basis: - Conservation of coherence: C_parent ≥ α·ΣC_child_i - Factor α = (1/√N)·η_phase(N)·η_coupling(N) ∈ [0.1, 0.4] - Operates in SPATIAL dimension (hierarchy) vs U1-U4 (TEMPORAL) - Independent of U2+U4b per decision test case Metrics: U5 ensures bounded multi-scale evolution when depth>1 Co-authored-by: fermga <203334638+fermga@users.noreply.github.com>

Intent: Complete test coverage for U5 Multi-Scale Coherence rule Operators involved: REMESH (Recursivity), IL (Coherence), THOL (Self-organization) Affected invariants: #7 (Operational Fractality) Key changes: - Created test_u5_multiscale_coherence.py with 25 comprehensive tests - Test operator sets, shallow/deep recursion, stabilizer windows, edge cases - Test U5 independence from U2+U4b (decisive test case) - Test U5 integration with complete grammar pipeline - Fixed existing test expecting 7 messages (now 8 with U5) - Fixed THOL test to include U4b context (destabilizer) Test coverage: - Shallow recursion (depth=1): passes without stabilizer ✓ - Deep recursion (depth>1): fails without stabilizer ✓ - Deep recursion with stabilizers: passes ✓ - Stabilizer window (±3 operators): enforced ✓ - Independence from U2+U4b: proven ✓ - Integration with all rules: verified ✓ All 93 grammar tests pass (68 existing + 25 new U5 tests) Co-authored-by: fermga <203334638+fermga@users.noreply.github.com>

Intent: Demonstrate U5 emerges inevitably from nodal equation, equal to other rules Operators involved: REMESH (Recursivity), IL (Coherence), THOL (Self-organization) Affected invariants: #7 (Fractality), #9 (Structural Metrics) Key changes: - Added complete 8-step derivation from ∂EPI/∂t = νf·ΔNFR(t) - Showed chain rule inevitably leads to C_parent ≥ α·ΣC_child - Demonstrated α = (1/√N)·η_phase·η_coupling from coupling physics - Added detailed canonicity section equal to U1-U4 sections - Proved independence from U2+U4b (spatial vs temporal dimensions) - Updated all summaries to include U5 as seventh sub-rule Physical traceability: 1. Nodal equation (axiomatic): ∂EPI/∂t = νf·ΔNFR 2. Hierarchical coupling (Inv. #7): EPI_parent = f(EPI_child_i) 3. Chain rule (calculus): ∂EPI_parent/∂t = Σ w_i·∂EPI_child_i/∂t 4. Coherence definition (Inv. #9): C ~ 1/|ΔNFR| 5. Conservation inequality: Mathematical consequence → C_parent ≥ α·ΣC_child 6. Stabilizer necessity: Only way to maintain conservation Canonicity: STRONG (inevitable given Invariants #7 and #9) Documentation quality: Equal to or better than U1-U4 Co-authored-by: fermga <203334638+fermga@users.noreply.github.com>

…1-U4 - Added full U5 section to 02-CANONICAL-CONSTRAINTS.md with same depth as U1-U4 * Intuition, Formal Definition, Physical Derivation * Implementation code examples * Valid/invalid examples and anti-patterns * Test specifications and related documentation - Updated all grammar documentation files (33+ files) to reflect U5 * MASTER-INDEX.md: System overview and conceptual hierarchy * 08-QUICK-REFERENCE.md: Constraint box, decision tree, examples * 06-VALIDATION-AND-TESTING.md: Coverage checklist and requirements * 01-FUNDAMENTAL-CONCEPTS.md: Learning path references * GLOSSARY.md: Grammar definition and sequence validation * EXECUTIVE-SUMMARY.md: Business value and constraint count - Updated technical implementation documentation * 05-TECHNICAL-IMPLEMENTATION.md: Architecture and validation logic * 04-VALID-SEQUENCES.md: Validation algorithms and notes * 07-MIGRATION-AND-EVOLUTION.md: Phase 3 current state, breaking changes - Updated operator classification references * Added RECURSIVE_GENERATORS and SCALE_STABILIZERS to all relevant docs * Updated all code docstrings from 'U1-U4' to 'U1-U5' * Updated Summary Table and Complete Validation Example - Implementation note: U5 already exists in codebase (grammar.py) * Tests exist (test_u5_multiscale_coherence.py) * This commit achieves documentation completeness only Physics basis: C_parent >= α·ΣC_child (hierarchical coherence conservation) U5 requirement: Deep REMESH (depth>1) needs IL/THOL within ±3 operators Refs: AGENTS.md (Invariant #7: Operational Fractality), UNIFIED_GRAMMAR_RULES.md

fix: import math before use in phase sync observer

6965713

Move math import to module level and remove delayed import inside sincronía_fase. Add regression test ensuring phase_sync and kuramoto_R metrics are recorded in history.

fermga added the codex label Aug 27, 2025 — with ChatGPT Codex Connector

fermga merged commit 1824fd2 into main Aug 27, 2025
0 of 4 checks passed

fermga deleted the codex/review-codebase-for-issues branch August 27, 2025 19:11

Copilot AI mentioned this pull request Nov 4, 2025

Add JSON/YAML/pickle serialization support for BEPIElement #2483

Merged

fermga mentioned this pull request Nov 5, 2025

Problema crítico: 127 test failures pre-existentes impactan la fiabilidad del motor TNFR #2563

Closed

Copilot AI mentioned this pull request Nov 10, 2025

Implement U5: Multi-Scale Coherence grammar rule for hierarchical REMESH structures #2916

Merged

35 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix phase sync observer math import and add history test #7

Fix phase sync observer math import and add history test #7

Uh oh!

fermga commented Aug 27, 2025

Uh oh!

netlify bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix phase sync observer math import and add history test #7

Fix phase sync observer math import and add history test #7

Uh oh!

Conversation

fermga commented Aug 27, 2025

Summary

Testing

Uh oh!

netlify bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for stunning-zabaione-f1f1ef failed. Why did it fail? →

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Aug 27, 2025 •

edited

Loading