Skip to content

Fix TUI mypy failure from _auto_refresh override collision#6

Merged
fernandogarzaaa merged 1 commit into
feat/beta-improvementsfrom
copilot/fix-open-drop-action-error
May 14, 2026
Merged

Fix TUI mypy failure from _auto_refresh override collision#6
fernandogarzaaa merged 1 commit into
feat/beta-improvementsfrom
copilot/fix-open-drop-action-error

Conversation

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

CI type-check failed because OpenDropTUI._auto_refresh accidentally collided with DOMNode._auto_refresh and introduced an incompatible async override signature. This change removes the override conflict without changing refresh behavior.

  • Type-check remediation

    • Renamed OpenDropTUI private coroutine _auto_refresh_refresh_models_table
    • Updated internal call sites in action_refresh and set_interval(...)
  • Behavioral impact

    • No intended runtime behavior change; manual and interval-driven model table refresh continue to run through the same logic
  • Illustrative diff

# before
self.set_interval(self.REFRESH_INTERVAL, self._auto_refresh)
async def _auto_refresh(self) -> None: ...

# after
self.set_interval(self.REFRESH_INTERVAL, self._refresh_models_table)
async def _refresh_models_table(self) -> None: ...

Beta readiness checklist

  • Lint and format checks pass
  • Tests pass
  • Type checks pass
  • Packaging build passes
  • Security impact assessed
  • Docs updated (if behavior changed)

Risk and rollback

Risk is low: scope is limited to a private method rename and its local call sites in TUI refresh wiring.
Rollback is straightforward: revert this commit to restore the previous method name/calls.

Agent-Logs-Url: https://github.com/fernandogarzaaa/OpenDrop/sessions/2ad2fbdd-bbdf-4b54-b0cd-b54a36ee3793

Co-authored-by: fernandogarzaaa <99188227+fernandogarzaaa@users.noreply.github.com>
@fernandogarzaaa
fernandogarzaaa marked this pull request as ready for review May 14, 2026 12:28
Copilot AI review requested due to automatic review settings May 14, 2026 12:29
@fernandogarzaaa
fernandogarzaaa merged commit 5ad980c into feat/beta-improvements May 14, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants