Skip to content

Added capability for .remote() to contact the DHT (BEP46)#38

Closed
lmatteis wants to merge 9 commits into
webtorrent:masterfrom
lmatteis:master
Closed

Added capability for .remote() to contact the DHT (BEP46)#38
lmatteis wants to merge 9 commits into
webtorrent:masterfrom
lmatteis:master

Conversation

@lmatteis

Copy link
Copy Markdown

@lmatteis

Copy link
Copy Markdown
Author

@yciabaud fixed the travis issue, but now the test-browser fails, which btw also fails locally. Seems a credentials problem with saucelabs.

@lmatteis

Copy link
Copy Markdown
Author

poke @feross

@feross

feross commented Sep 1, 2016

Copy link
Copy Markdown
Member

Sorry traveling in China for another week with sparse Internet. Will check
this out when I get back.
On Tue, Aug 30, 2016 at 8:35 PM Luca Matteis notifications@github.com
wrote:

poke @feross https://github.com/feross


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHbpvPug9VZsD-49LySYk_ddpsT6MVVks5qlCOFgaJpZM4JpTzB
.

@HostFat

HostFat commented Sep 17, 2016

Copy link
Copy Markdown

Any news on this?

@jabyrd3

jabyrd3 commented Nov 1, 2016

Copy link
Copy Markdown

Just want to sub to this so I can get an update whenever @feross is around.

@lmatteis

lmatteis commented Feb 9, 2017

Copy link
Copy Markdown
Author

@feross any news on this? The test errors are because of saucelabs credentials. It's missing the salt so I'll work on that as soon as I can.

@matthewaveryusa

Copy link
Copy Markdown

@feross @lmatteis is this just a matter of adding the following snippit at the beginning of test.js

var runSauceLabs = !process.env.CI ||
  (process.env.SAUCE_USERNAME && process.env.SAUCE_ACCESS_KEY)

if(!runSauceLabs) { process.exit(0); }

I think it's related to this: defunctzombie/zuul#86

I also noticed that the travis link is broken. It points to feross/... but the actual location is webtorrent/...

@matthewaveryusa

Copy link
Copy Markdown

Well, a bit more than that. Basically copying what is done in webtorrent/package.json to short-circuit the sauce issue for PRs. I can submit a separate PR to do this if that's what's needed to unblock this PR.

@matthewaveryusa

Copy link
Copy Markdown

submitted #46 for what I mentioned above. Should be all squared away

@RangerMauve

Copy link
Copy Markdown

Have the CI issues been fixed since this was created? Would a new PR that adds this functionality be welcome?

@RangerMauve

Copy link
Copy Markdown

@DiegoRBaquero Was this closed because it's been implemented? Or is it just very out of date?

@DiegoRBaquero

Copy link
Copy Markdown
Member

Closed in favor of #58

@RangerMauve

Copy link
Copy Markdown

Thank you for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants