feat: add realm role get/delete and client-scoped roles - #30
Merged
Conversation
|
Warning Review limit reachedNext included review available in 29 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
realm role get <name> [--client <client_id>]— look up a realm or client role by name.realm role delete <name> [--client <client_id>]— delete a realm or client role (confirmation prompt,--forceto skip).--client <client_id>onrole createandrole list— reach client roles, not just realm roles.delete_role,list_client_roles, following therealms/{realm}/[clients/{uuid}/]roles[/{id}]convention used elsewhere.create_client_rolewas already there but decoded its response as an enveloped{"data": ...}payload likecreate_role— turns out that endpoint returns the role as a bare object; fixed. There's no client-scoped delete endpoint — role ids are unique across realm and client scopes, so plaindelete_roledeletes both; dropped thedelete_client_rolemethod I'd initially guessed at.Issue
Closes #22.
Verification
Verified live against a local FerrisKey server (create/get/list/delete, both realm-scoped and client-scoped roles) — not just unit tests. Caught and fixed one real bug in the process (the
create_client_roleenvelope mismatch above) and dropped one endpoint that doesn't exist server-side.Test plan
cargo build --workspacecargo test --workspace(60 passed)cargo clippy --workspace --all-targets --all-features -- -D warningsrole create/get/list/delete, realm-scoped and--client-scoped, then cleaned up the test fixtures