Update for DOLFINx v0.11#1173
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 94.76% 94.77% +0.01%
==========================================
Files 46 46
Lines 3534 3428 -106
==========================================
- Hits 3349 3249 -100
+ Misses 185 179 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| J=self.J, | ||
| petsc_options=petsc_options, | ||
| petsc_options_prefix="festim_solver", | ||
| kind="mpi", |
There was a problem hiding this comment.
@jorgensd I was running into some issues getting the solver to work in a case with a blocked system of 1 block, i.e. when we have a discontinuous case with a single volume. It seems some new logic was added to make things more efficient when possible, and it wouldn't assign block data. Although I found this neat little fix. What do you think?
There was a problem hiding this comment.
I have also stumbled upon the 1-block being not blocked issue when I made irksome, and also added a workaround. I'll have a look at this PR sometime this weekend and see if the fix is the same.
Description
Fix for #1174
Summary
This pull request updates FESTIM to support newer versions of dolfinx and replaces the dependency on
adios4dolfinxwithio4dolfinx. It also simplifies handling of interpolation points by removing version checks and using the direct attribute access now standard in dolfinx >=0.10.0. The PR updates all relevant dependencies and documentation, and cleans up code that was only needed for older dolfinx versions.Related Issues
Motivation and Context
Type of Change
Testing
pytest)Code Quality Checklist
ruff format .)ruff check .)Documentation
Breaking Changes
Screenshots/Examples
Additional Notes