Species class#585
Merged
Merged
Conversation
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #585 +/- ##
============================================
+ Coverage 0.00% 91.57% +91.57%
============================================
Files 4 5 +1
Lines 79 95 +16
============================================
+ Hits 0 87 +87
+ Misses 79 8 -71
☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@gabriele-ferrero @jhdark could you take a look at this? |
Collaborator
|
Looks good to me, the gas_permeation test needs some modifications but can be done in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial Species and Trap classes
They are mostly empty for now and can just hold solutions, previous solutions, test functions