Time dependent temperature#620
Merged
RemDelaporteMathurin merged 29 commits intoNov 1, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #620 +/- ##
========================================
Coverage 98.18% 98.19%
========================================
Files 16 16
Lines 552 610 +58
========================================
+ Hits 542 599 +57
- Misses 10 11 +1
☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Oct 30, 2023
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Looks great. First round of comments to improve things
RemDelaporteMathurin
requested changes
Oct 31, 2023
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
RemDelaporteMathurin
approved these changes
Nov 1, 2023
Collaborator
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
Happy to merge this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This update would allow users to define temperature using a callable meaning the temperature can be a function of space or time. When a time_dependent temperature function is given, an attribute temperature_time_dependent is then True, which will then update the temperature function at each time step.
Usage:
or
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...