Skip to content

Iterate method#621

Merged
RemDelaporteMathurin merged 3 commits into
fenicsxfrom
iterate
Oct 31, 2023
Merged

Iterate method#621
RemDelaporteMathurin merged 3 commits into
fenicsxfrom
iterate

Conversation

@RemDelaporteMathurin
Copy link
Copy Markdown
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin commented Oct 31, 2023

As discussed in #620 , this adds an .iterate method to HydrogenTransportProblem to refactor the run method a bit.

Temporarily, I added a skip_post_processing boolean flag to the method (defaulting to False) to simplify the test since most of what we have in the post-processing atm will go away.

I also added a test for iterate. It doesn't test everything but tried to keep it small.

Notes:

  • we would need to add unit tests for the methods of HydrogenTransportProblem
  • I added a bunch of new undocumented attributes for communication between run and iterate. These will be removed as soon as we have a proper post-processing step

@RemDelaporteMathurin RemDelaporteMathurin added the fenicsx Issue that is related to the fenicsx support label Oct 31, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b975a64) 98.17% compared to head (a9fa55b) 98.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #621   +/-   ##
========================================
  Coverage    98.17%   98.18%           
========================================
  Files           16       16           
  Lines          549      552    +3     
========================================
+ Hits           539      542    +3     
  Misses          10       10           
Files Coverage Δ
festim/hydrogen_transport_problem.py 99.48% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@jhdark jhdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@RemDelaporteMathurin RemDelaporteMathurin merged commit 2af2937 into fenicsx Oct 31, 2023
@RemDelaporteMathurin RemDelaporteMathurin deleted the iterate branch November 3, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fenicsx Issue that is related to the fenicsx support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants