Patch derived quantity overwriting csv file#706
Merged
jhdark merged 4 commits intoMar 7, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #706 +/- ##
========================================
Coverage 99.09% 99.10%
========================================
Files 24 24
Lines 1110 1112 +2
========================================
+ Hits 1100 1102 +2
Misses 10 10 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Yeah don't think anything is needed in the doc strings for this hidden attribute as it should get a given, we could potentially add a note in the docs later down the line, but otherwise this is good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is a patch to #705
I just reworked the logic to check if it's the first time we write the csv and if so write the file and write the header, otherwise just append to it.
That requires to add another attribute
._first_time_export, I don't know if we should document it or not but I added _ to say it's a private attribute. What do you think @jhdark ?Types of changes
What types of changes does your code introduce to FESTIM?
Checklist