Skip to content

Risp pulse#36

Merged
kaelyndunnell merged 69 commits into
mainfrom
risp-pulse
Nov 4, 2024
Merged

Risp pulse#36
kaelyndunnell merged 69 commits into
mainfrom
risp-pulse

Conversation

@kaelyndunnell
Copy link
Copy Markdown
Collaborator

@kaelyndunnell kaelyndunnell commented Nov 4, 2024

Adds:

Changes:

  • Refactors code by moving FESTIM mb model (boundary conditions, material parameters, etc.) to src and leaving user to specify how temperature and particle fluxes evolve over time

kaelyndunnell and others added 30 commits October 31, 2024 14:36
@kaelyndunnell
dummy RISP wall data
b0efd4e
@kaelyndunnell
dummy RISP and ROSP data
45e04cb
@kaelyndunnell
added RISP pulse, seems to be computation error on first RISP pulse i…
8de5ae1 
…n scenario but not second
@RemDelaporteMathurin
refactor if statements
d5c2a10
@RemDelaporteMathurin
use as_fenics_constant
f9fee54
@RemDelaporteMathurin
t is always float in fluxes
7c9a8c6
@RemDelaporteMathurin
gaussian distr in helpers
54f901b
@RemDelaporteMathurin
type hinting for gaussian
2856cc1
@RemDelaporteMathurin
todo
4aa00fc
@RemDelaporteMathurin
moved RISP_data out
89b7227
@RemDelaporteMathurin
refac heat()
4b97425
@RemDelaporteMathurin
moved dict out
81b4455
@RemDelaporteMathurin
simplify indexing with ion
dcf1ef3
@RemDelaporteMathurin
relative time instead of t
ec2ee73
@RemDelaporteMathurin
moved get_flux out
3ef7d80
@RemDelaporteMathurin
type hint
c0bfbf4
@RemDelaporteMathurin
moved heat out
0e14e8f
@RemDelaporteMathurin
new make_mb_model function
2293328
@RemDelaporteMathurin
added TODO
991e5ee
@RemDelaporteMathurin
added TODO
1e9c51c
@RemDelaporteMathurin
explicit relative time for get_particle_flux
0e49ae1
@kaelyndunnell
adjusted time input for heat() to accept relative time
76d0aca
@RemDelaporteMathurin
refactored temp
a8a22b6
@RemDelaporteMathurin
removed T_rear and T_surf
12e43ab
@RemDelaporteMathurin
type hinting
3c18593
@RemDelaporteMathurin
assert and refactoring of particle fluxes
e9e428b
@RemDelaporteMathurin
simplify return
4c8a3d4
@RemDelaporteMathurin
black formatting
b372b2c
@RemDelaporteMathurin
monob argument is now nb_mb
31cbd91
@RemDelaporteMathurin
comments
e56cba1
@kaelyndunnell kaelyndunnell linked an issue Nov 4, 2024 that may be closed by this pull request
Fix scenario file format #28
Closed
This was linked to issues Nov 4, 2024
RISP Pulse Type #16
Closed
Cleaning Pulses #17
Closed
Create scenario in Python and export to input .txt file #27
Closed
RemDelaporteMathurin
RemDelaporteMathurin requested changes Nov 4, 2024
View reviewed changes
Comment thread environment.yml
Comment thread pyproject.toml Outdated
Comment thread scenario_test.txt Outdated
@kaelyndunnell kaelyndunnell merged commit ec9cb5d into main Nov 4, 2024
@kaelyndunnell kaelyndunnell deleted the risp-pulse branch November 4, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemDelaporteMathurin RemDelaporteMathurin RemDelaporteMathurin requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix scenario file format Create scenario in Python and export to input .txt file Cleaning Pulses RISP Pulse Type

2 participants

@kaelyndunnell @RemDelaporteMathurin