Misc fixes for coupled setup#72
Merged
Merged
Conversation
joewallwork
commented
Jan 21, 2025
| photolysis: | ||
| activate: true | ||
| input_directories: | ||
| fastjx_input_dir: /home/joe/data/GISS-GC/prod_input_files/ExtData/CHEM_INPUTS/FAST_JX/v2021-10/ |
Collaborator
Author
There was a problem hiding this comment.
FAST_JX input data updated to more recent version, as recommended by @ltmurray.
joewallwork
commented
Jan 21, 2025
Collaborator
Author
There was a problem hiding this comment.
Just ordering of gitignore and adding in various GISS-GC specific files to avoid annoying output upon calling git status.
joewallwork
commented
Jan 21, 2025
joewallwork
commented
Jan 21, 2025
| # GISS-GC high-level CMakeLists.txt | ||
|
|
||
| cmake_minimum_required (VERSION 3.13) | ||
| project (geos-chem-classic |
Collaborator
Author
There was a problem hiding this comment.
More appropriate project name in the CMake.
joewallwork
commented
Jan 21, 2025
| #------------------------------------------------------------------------- | ||
| set(GCHP FALSE PARENT_SCOPE) | ||
| # LTM: Need to set this to false to get GISS-GC to compile | ||
| set(MODEL_GISS TRUE PARENT_SCOPE) |
Collaborator
Author
There was a problem hiding this comment.
Not sure why this wasn't defined?
joewallwork
commented
Jan 23, 2025
| endif | ||
| CTM_LFLAGS = $(LFLAGS) | ||
| ifeq ($(GC),YES) | ||
| CTM_LFLAGS += -nostartfiles |
Collaborator
Author
There was a problem hiding this comment.
It turns out this compiler flag is required with the Intel compiler.
AdelekeBankole
previously approved these changes
Feb 4, 2025
AdelekeBankole
left a comment
AdelekeBankole
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me!
* Turn on verbose output for GEOS-Chem * Use executable rather than .exe * Shellcheck run.sh * Shellcheck setup.sh * Shellcheck build.sh * Don't use xterm with gdb * Command line option for COMPILE_WITH_TRAPS * Add GitHub Actions workflow for linting * Apply formatting fixes to GitHub Actions workflows * Cancel running test suite job if new commit pushed * Similarly for Docker workflow * Consistent printing of env vars * Post-merge fix * Lint fix; apply to set_gcclassic_rundir.sh
AdelekeBankole
approved these changes
Feb 4, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71.
With the changes in this PR, I am able to get past configuration errors and run the coupled model on CSD3. It crashes with an
error, but this occurs during the chemistry solve, i.e., after configuration has finished.
To review this, please check that you are able to build and run up to this point on CSD3.