[capricorn] Upgrade to cosmwasm 1.0.0. beta #48
Conversation
daeMOn63
changed the title
ejfitzgerald
left a comment
ejfitzgerald
left a comment
There was a problem hiding this comment.
Is it possible to remove fetch/bridge.wasm and then just build it and attach to part of the release like I have done in: https://github.com/fetchai/contract-reconciliation. Think that is a nicer way to do things
| out_dir.push("schema"); | ||
| create_dir_all(&out_dir).unwrap(); | ||
| remove_schemas(&out_dir).unwrap(); | ||
| /* |
There was a problem hiding this comment.
Will add an item on to the backlog to add this back in at some point
There was a problem hiding this comment.
added back, that wasn't too hard :)
| Some(_) => true, | ||
| None => false, | ||
| } | ||
| store.get(&swap_id.to_be_bytes()).is_some() |
| Ok(r) | ||
| Ok(Response::new() | ||
| .add_attributes(attrs) | ||
| .add_submessages(rtx.messages)) |
There was a problem hiding this comment.
This is a functional difference right? Did you expect to call .add_message it might not make much of the difference but my recollection is that sub messages are ones where the contract is interested in the response.
There was a problem hiding this comment.
I think I'm forced to use .add_submessages here because of message signature: pub messages: Vec<SubMsg<T>, Global>. Using .add_message result in the trait bound 'cosmwasm_std::CosmosMsg<_>: From<SubMsg>' is not satisfied
| Ok(r) | ||
| Ok(Response::new() | ||
| .add_attributes(attrs) | ||
| .add_submessages(rtx.messages)) |
| pub mod msg; | ||
| pub mod state; | ||
|
|
||
| #[cfg(test)] |
|
|
||
| on: [push, pull_request] | ||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
| pull_request: | |
| pull_request: | |
| - master |
I seem to remember that you need this
There was a problem hiding this comment.
I'm not sure to see why would we want to restrict actions to run only for PR targeting master? Running for any PR seems fine?
ejfitzgerald
left a comment
ejfitzgerald
left a comment
There was a problem hiding this comment.
Looks good to me - I guess we need to sort out the GH actions though because they don't look like they are working currently
No description provided.