Fix filehandle.t: Add DESTROY method to IO::Handle #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileHandle.pm expects to import IO::Handle::DESTROY, but it wasn't defined. Added an empty DESTROY method to satisfy this requirement. The actual cleanup happens in Java when the JVM garbage collects the object. Fixes: t/op/filehandle.t (4/4 tests now pass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FileHandle.pm expects to import IO::Handle::DESTROY, but it wasn't defined.
Changes
Test Results
✅ t/op/filehandle.t: 4/4 tests now pass (was 0/4)
Details
The error was:
FileHandle.pm line 63-64 explicitly imports DESTROY from IO::Handle, but the method wasn't defined in IO::Handle.pm.