Fix typeglob CODE slot access for filehandle.t #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real issue was that *{name}{CODE} wasn't calling RuntimeGlob's
hashDerefGet() method - it was using the parent RuntimeScalar's version
which treats the glob as a hash dereference.
Fixes:
1. Override hashDerefGetNonStrict() in RuntimeGlob to properly handle
typeglob slot access (CODE, SCALAR, ARRAY, HASH, IO, FORMAT)
2. Check RuntimeCode.defined() before returning CODE slot to match
standard Perl behavior where undefined subs don't appear in CODE slot
3. Add missing IO::Handle methods: gets(), _open_mode_string()
4. Add missing IO::Seekable methods: getpos(), setpos()
5. Add missing IO::File method: new_tmpfile() (stub for now)
6. Keep DESTROY method in IO::Handle for compatibility
Test Results: t/op/filehandle.t now passes 4/4 tests
fglock
force-pushed
the
fix/filehandle-t
branch
from
611ab2a to
98afe8e
Compare
- Add RuntimeIO.selectedGlob to track the selected filehandle glob - Update IOOperator.select() to return the glob name instead of GLOB(0xHASHCODE) - Fix RuntimeGlob.toString() to return the glob name without '*' prefix - Fix RuntimeScalar.undefine() to handle CODE type properly without crashing This fixes t/uni/select.t (3/5 tests pass, 2 TODO) and t/op/undef.t.
Add parseUndef() method that sets parsingTakeReference flag, similar to parseDefined(). This prevents &foo from being auto-called when used with undef, allowing undef &foo to properly undefine the subroutine instead of trying to undefine the return value (which may be read-only). This is the proper fix for the 'Modification of a read-only value attempted' error when using undef &sub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the fix for
t/op/filehandle.tby properly implementing typeglob CODE slot access.Root Cause
The previous PR #66 only added the missing DESTROY method, but the real issue was that
*{name}{CODE}wasn't working properly. When FileHandle.pm checked for method existence using*{"IO::Handle::method"}{CODE}, it was callingRuntimeScalar.hashDerefGetNonStrict()instead of accessing the typeglob's CODE slot.Changes
hashDerefGetNonStrict()inRuntimeGlobto properly handle typeglob slot access (CODE, SCALAR, ARRAY, HASH, IO, FORMAT)RuntimeCode.defined()before returning CODE slot to match Perl behavior where undefined subs return undefIO::Handle:gets(),_open_mode_string()IO::Seekable:getpos(),setpos()IO::File:new_tmpfile()(stub for now)Test Results
✅
t/op/filehandle.t: 4/4 tests pass (was 0/4 before PR #66)Bonus Improvements
This fix also improved other tests:
t/op/undef.t: +23 tests (15 → 38 tests passing, previously crashed)t/uni/select.t: +3 tests (0 → 3/5 tests passing)Technical Details
Used
--disassembleto confirm that*{name}{CODE}compiles tohashDerefGetNonStrict, which was missing the override inRuntimeGlob.