node-dev breaks cluster api

[andrewrk]

http://nodejs.org/api/cluster.html#cluster_cluster_ismaster

cluster.isMaster always returns true when using node-dev.

[fgnass]

Did you run test/cluster.js?

It should yield the following output:

Forking worker 0
Forking worker 1
Message from worker: { cmd: 'online', _queryId: 1, _workerId: 2 }
Message from worker: { cmd: 'online', _queryId: 1, _workerId: 1 }
Message from worker: { cmd: 'online', _queryId: 1, _workerId: 1 }
Message from worker: { cmd: 'online', _queryId: 1, _workerId: 2 }
Message from worker: *** Worker started! ***
Message from worker: *** Worker started! ***
Message from worker: { cmd: 'queryServer',
  address: '0.0.0.0',
  port: 8000,
  addressType: 4,
  _queryId: 2,
  _workerId: 2 }
Message from worker: { cmd: 'queryServer',
  address: '0.0.0.0',
  port: 8000,
  addressType: 4,
  _queryId: 2,
  _workerId: 1 }
Server running at http://127.0.0.1:8000/
Hello world! Try changing message.js while the process is running.
Server running at http://127.0.0.1:8000/
Hello world! Try changing message.js while the process is running.

[andrewrk]

$ ./node-dev test/cluster.js 
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 0
Forking worker 1
Forking worker 1
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 0
Forking worker 1
Forking worker 0
Forking worker 1
Forking worker 1
Forking worker 1
.
.
.

This goes on continually until all system resources are exhausted. I'll see if I can come up with a fix.

Ubuntu 12.04 64-bit
Node v0.8.7

[andrewrk]

I just read through all the code and it looks like you're passing the environment around correctly. I don't know what the problem is. I'd be happy to provide you with ssh access to my box if you want to play around. send a privmsg to superjoe on Freenode if you want.

[fgnass]

Strange indeed. Which node version do you use?

[andrewrk]

I edited the earlier message with this text, so if you were reading github notifications you might have missed this:

Ubuntu 12.04 64-bit
Node v0.8.7

[andrewrk]

Same behavior with Node v0.8.8

[fgnass]

Okay, I can reproduce the issue with node 0.8.x - it does work in 0.6.x though.

[andrewrk]

Thanks!

[andrewrk]

Actually this is still broken. Here's a failing test case:

var cluster = require('cluster');

if (cluster.isMaster) {
  worker = cluster.fork();
} else {
  require('http').createServer().listen(13116, 'localhost', function () {
    console.log("listening at http://localhost:13116/");
  });
}

Output when run with node:

$ node test.js 
listening at http://localhost:13116/

Output when run with node-dev:

$ node-dev test.js 
<no output>

[fgnass]

Yeah, I know :( Passing the socket handle via the ipc channel fails. It's alread fixed in the 2.0 branch, but due to the complete rewrite it will take some more time before it gets released. I'm currently stuck on another project but I'll come back to this in two weeks, so stay tuned. Meanwile you can of course try out the 2.0 branch, it would be interesting to hear if it works for you.