Add Elixir Heex templates#863
Merged
Alhadis merged 1 commit intofile-icons:masterfrom Nov 14, 2021
aj-foster:patch-1
Merged
Conversation
Alhadis
requested changes
Nov 13, 2021
Member
Alhadis
left a comment
Alhadis
left a comment
There was a problem hiding this comment.
Thanks for the submission! Just a few small nits to address, but nothing major.
Contributor
Author
|
All great comments. Addressed those and squashed the branch. 🙂 |
Alhadis
approved these changes
Nov 14, 2021
Member
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there 👋🏼
This PR adds support for Elixir's Heex templates (
.heexas well as.html.heex) using existing rules.Thank you for your work on this project!