Conversation
Always use the dummy path when requesting icons so the shell resolves the generic icon from the extension alone (works for local, MTP, FTP, network, cloud, etc.). Remove dependency on FileExtensionHelpers in IconCacheService and simplify icon path selection to use dummy path + extension for files. Add a cached IIconCacheService instance in UniversalStorageEnumerator and preload PreloadedIconData for folder and file entries by calling GetIconAsync to improve icon availability/performance in the enumerator.
yair100
changed the title
yair100
changed the title
yair100
added
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15084
Also fixes an issue where placeholder icons didn't display for folders enumerated with StorageItem.