Skip to content

Fix: Fixed issue with copying text from rename text box - #18832

Merged
yair100 merged 3 commits into
files-community:mainfrom
XAN9xXx:fix/18820-rename-copy-shortcut
Aug 18, 2026
Merged

Fix: Fixed issue with copying text from rename text box#18832
yair100 merged 3 commits into
files-community:mainfrom
XAN9xXx:fix/18820-rename-copy-shortcut

Conversation

@XAN9xXx

@XAN9xXx XAN9xXx commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Resolved / Related Issues

Description

Opening the item context menu leaves its primary command keyboard accelerators active after the flyout closes. This allows the CopyItem command to override Ctrl+C while the rename TextBox has focus.

This change clears the primary command button accelerators when FastContextFlyout closes.

Steps used to test these changes

  1. Opened Files and selected a folder.
  2. Opened and closed the item context menu.
  3. Started renaming the selected folder from the command bar.
  4. Selected part of the name and pressed Ctrl+C.
  5. Pasted into another text box and verified that the selected text was copied instead of the folder.
  6. Exited rename mode, selected a folder, and verified that Ctrl+C still copies the selected folder.

@CLAassistant

CLAassistant commented Aug 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread src/Files.App/Helpers/MenuFlyout/FastContextFlyout.cs Outdated
@yair100 yair100 changed the title Fix: Prevent context menu accelerators from overriding rename text copy Fix: Fixed issue with copying text from rename text box Aug 18, 2026
# Conflicts:
#	src/Files.App/Helpers/MenuFlyout/FastContextFlyout.cs
@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Aug 18, 2026
@yair100

yair100 commented Aug 18, 2026

Copy link
Copy Markdown
Member

@XAN9xXx congrats on your first PR to Files!

@yair100
yair100 merged commit ef734d8 into files-community:main Aug 18, 2026
7 checks passed
@XAN9xXx

XAN9xXx commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Glad to contribute, and thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Can't copy text from rename text box

3 participants