fix(release): attach the sdist and wheel to the GitHub Release - #4
Merged
Conversation
The semantic-release action only runs 'version' — it bumps, tags, writes the changelog and creates the GitHub Release, but it never runs 'publish'. So every Release was created with no files attached: a bare tag pointing at PyPI. Upload the sdist and wheel that semantic-release already built, so the Release stands on its own. That matters for a tool whose whole purpose is to be an escape hatch — you should be able to grab it from GitHub without going through a package index. Uses the preinstalled gh CLI rather than another action, so the org's Actions allow-list does not need a new entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
python-semantic-releaseaction only runsversion— it bumps, tags, writes the changelog and creates the GitHub Release, but it never runspublish. So every Release so far was created with no files attached: a bare tag pointing at PyPI.Upload the sdist + wheel that semantic-release already built into
dist/, so the Release stands on its own. That matters for a tool whose entire purpose is to be an escape hatch — you should be able to grab it straight from GitHub without going through a package index.Uses the preinstalled
ghCLI rather than adding another action, so the org's Actions allow-list needs no new entry.This is also the trial release the plan calls for: merging it cuts
v0.0.3, which should exercise the full chain end to end — semantic-release → PyPI → and the Homebrew formula bump, now thatTAP_DISPATCH_TOKENis scoped correctly.