test(conformance): gate user channel membership APIs#1975
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1975 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 85 85
Lines 6698 6698
Branches 1044 1044
=======================================
Hits 6385 6385
Misses 313 313 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Two small improvements that need making, otherwsie LGTM.
Should be tested using the reference implementation for at least the positive case (i.e. UserChannelMembershipAPIs == true)
| try { | ||
| const channels = await fdc3.getUserChannels(); | ||
| if (channels.length === 0) { | ||
| assert.fail('No system channels available'); |
There was a problem hiding this comment.
| assert.fail('No system channels available'); | |
| assert.fail('No user channels available'); |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Test definition in docs also needs to be updated when a test is changed
# Conflicts: # CHANGELOG.md
|
Please resolve Changelog conflict (I would do it for you but I can't then approve and merge). I think these occur less if you add to the bottom of the changelog section you are updating instead of the top. |
…el-conformance-1777 # Conflicts: # CHANGELOG.md
|
Resolved the CHANGELOG conflict against current |
3 participants
Describe your change
Updates the BasicJC1 conformance test so user-channel membership APIs are exercised only when
getInfo().optionalFeatures.UserChannelMembershipAPIsis advertised. Implementations without the optional feature no longer fail the basic suite, while implementations that advertise it still validatejoinUserChannel,getCurrentChannel, andleaveCurrentChannel.Resolves #1777.
Contributor License Agreement
Validation
npm --workspace toolbox/fdc3-conformance run buildgit diff --check origin/main...HEAD