Skip to content

7.0.0-dev.108

Choose a tag to compare

View all tags
@ReleaseManagement-BP ReleaseManagement-BP released this 22 May 11:47
7.0.0-dev.108
26021a8
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

CDM Modelling - Fixing syntax warnings in [7dev]

Background

Fix the following errors in CDM

  • Cardinality warnings should be errors.
  • Override keyword should be mandatory when overriding attributes.
  • Cardinality mismatch between rule reference and attribute should be an error.
  • CheckAnnotationSource (duplicate types) in RosettaSimpleValidator.
  • Mandatory [metadata key] on types that are referenced.

What is being released?

  • Fixing cardinality warnings across CDM 7 dev namespaces.
  • Removing unused imports accross CDM 7 dev namespaces.
  • ExerciseInstruction: Attribute execriseOption changed to take type Payout from OptionPayout. As part of CDM upgrade, themetadata key on individual removed and instead referenced on the Payout choice type. Change required to fix a error OptionPayout must be annotated with [metadata key]. Create_Exercise function also updated to adhere to these changes
  • FinalCalulationPeriodDateAdjustment: Attribute swapSteamReference changed to take type Payout from InterestRatePayout. Same rational as above.

Review Directions

Changes can be reviewed in PR: #4691

Assets 2
Loading