Skip to content

7.0.0-dev.126

Choose a tag to compare

View all tags
@ReleaseManagement-BP ReleaseManagement-BP released this 29 Jun 10:19
7.0.0-dev.126
6e18f88
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Product Model - Fixes to datedValue

Background

It was possible for datedValue entries to be created without a date or a value.

What is being released?

These changes fix issues with how datedValue elements are created:

  • Function UpdateDatedValue
    • The cardinality of the changeAmount and effectiveDate inputs have been updated to be mandatory. This prevents datedValue entries from being created without a date or a value.
    • The creation of the newdatedValues output has been streamlined by calling UpdateAmount.
  • Function UpdateDatedValues
    • The same changes that were made to UpdateDatedValue have been made to this function too.
  • Function UpdatePriceAmountForEachMatchingQuantity
    • The setting of changeEffectiveDate and containsEffectiveDate have been moved to before the setting of changeAmount.
    • When setting changeAmount, the existence of changeEffectiveDate is now tested, as changedAmount should not be set if a date is present.
    • When setting updateDatedValues the existence of changeEffectiveDate is also now tested, as newdatedValues should only be set if a date is present.
  • Missed changes from PR 4693
    • Some of the changes requested from the review of #4690 were not transferred into the master PR #4693 that was merged into the model. These have been added back in.

Review Directions

Changes can be reviewed in PR: #4795

Assets 2
Loading