Skip to content

ci: prevent skipping dev dependencies on lint.yml - #1669

Merged
jescalada merged 3 commits into
mainfrom
bump-workflow-patch
Aug 12, 2026
Merged

ci: prevent skipping dev dependencies on lint.yml#1669
jescalada merged 3 commits into
mainfrom
bump-workflow-patch

Conversation

@jescalada

Copy link
Copy Markdown
Contributor

Description

Fixes linting failures on autogenerated bump PRs such as #1668

Related Issue

Resolves #

Checklist

General

Tests

  • Tests have been added/updated for new functionality
  • Unit tests pass (npm test)
  • Linting and formatting pass (npm run lint and npm run format:check)
  • Type checks pass (npm run check-types)

Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada
jescalada requested a review from a team as a code owner August 12, 2026 03:01
@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit c18649e
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a7c2f856c042a0007e1e1d8

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.17%. Comparing base (f0c773d) to head (c18649e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   90.26%   90.17%   -0.09%     
==========================================
  Files          89       89              
  Lines        8896     8896              
  Branches     1657     1657              
==========================================
- Hits         8030     8022       -8     
- Misses        834      842       +8     
  Partials       32       32              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Installs dependencies to prevent rewriting package-lock.json on bump PRs, also sets Node version to match lint.yml workflow

Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada

Copy link
Copy Markdown
Contributor Author

@finos/git-proxy-maintainers Need a review here to fix up the version bumper workflow which has a CI failure on #1668 🙏🏼

Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada
jescalada merged commit 28cd632 into main Aug 12, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants