[TRNF-7287] Feat(v2): Add entity onboardings and multipart uploads#127
Merged
Conversation
JoMarchant
force-pushed
the
feat/entities-onboarding
branch
5 times, most recently
from
c4c65ee to
ccdeb2d
Compare
Thread a `files` argument through the client and add a `resource_upload` handler so managers can send multipart/form-data via httpx; JWS signing is skipped for multipart bodies.
objetize treated floats as resources and crashed on `**float`; add float to the scalar passthrough list. Surfaced by the onboarding shareholder percentage.
Onboarding, OnboardingShareholder and OnboardingDocument resources, with mappings so nested shareholders/documents objetize to the right classes.
Onboardings nested under entities (entities.onboardings), mirroring account_statements: list, get, create, submit, and slot + shareholder document uploads (via resource_upload). Also enables entities.create.
JoMarchant
force-pushed
the
feat/entities-onboarding
branch
from
ccdeb2d to
78bb6aa
Compare
JoMarchant
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
Soporte en el SDK para el nuevo flujo de onboarding de entities de la API pública v2 (
/v2/entities/{id}/onboardings).Qué hay de nuevo?
POST /v2/entitiesPOST /v2/entities/{id}/onboardingsPUT /v2/entities/{id}/onboardings/{id}/shareholders/{id}/documentPUT /v2/entities/{id}/onboardings/{id}/documents/{slot_key}POST /v2/entities/{id}/onboardings/{id}/submitmultipart/form-dataen el cliente HTTP.Tests
Unitarios para el cliente multipart, los recursos y el manager (incluyendo las subidas de documentos). Probado end-to-end localmente contra fintoc-rails + pacioli (crear onboarding → subir documentos → submit).
Consideraciones
Las subidas multipart no se firman con JWS.
Rollback
¿Es seguro hacer rollback?
Sí
¿Cuáles son los pasos para hacer rollback?
Normal