fix(auth): use fixed padding for method picker provider buttons (#2424) - #2426
Merged
russellwheatley merged 2 commits intoJul 28, 2026
Merged
Conversation
Replace percentage-based horizontal padding (23% of screen width) with fixed 24dp padding and a 400dp max-width constraint. The old approach left only ~54% of screen width for buttons, causing labels like "Sign in with Facebook" to truncate on standard phone displays.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces BoxWithConstraints with a standard Box and simplifies the layout of the LazyColumn inside AuthMethodPicker by using a maximum width constraint of 400.dp and fixed horizontal padding. The reviewer correctly identified that on wider screens, the Box will wrap its content and align to the left instead of centering. To fix this, the reviewer suggested adding .fillMaxWidth() to the Box modifier so that contentAlignment = Alignment.TopCenter can take effect.
russellwheatley
approved these changes
Jul 28, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in studio-2394994192-60a69
demolaf
added a commit
that referenced
this pull request
Jul 29, 2026
…2404) * fix(auth): validate display name only when required in sign-up form (#2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test * fix(internal): append CHAR_LIMIT to translation descriptions in export script (#2417) Fixes #1613 * fix(auth): mitigate tapjacking on the auth activity window (#2416) Fixes #2041 * sample(app): add Firestore, Database & Storage demos to sample app (#2406) * fix(auth): allow customizing top app bar colors via AuthUITheme (#2391) * fix(auth): handle edge-to-edge insets in MFA challenge and auth screens (#2413) * fix(auth): use fixed padding for method picker provider buttons (#2424) (#2426) * fix(firestore): catch InterruptedException in FirestorePagingSource * fix(firestore): drop load error logging and restore rx error handler in test * fix(firestore): return LoadResult.Error for every load failure instead of throwing * fix(firestore): fix PageKey.equals NPE on null snapshots and add hashCode * test(firestore): run paging source test in CI via robolectric and replace sleeps with latches * fix(firestore): log genuine load failures while keeping cancellations silent --------- Co-authored-by: Oluwatobi Shokunbi <ayoshokz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthMethodPickerused percentage-based horizontal padding (23% of screen width), leaving only ~54% of the screen for button content.Fixes #2424
Test plan