Skip to content

test(auth): cover the write-through recoveries and the custom reauth slot's sheet chrome - #2476

Merged
russellwheatley merged 2 commits into
version-10.0.0-beta05from
feat/reauth-and-recovery-test-coverage
Sep 4, 2026
Merged

test(auth): cover the write-through recoveries and the custom reauth slot's sheet chrome#2476
russellwheatley merged 2 commits into
version-10.0.0-beta05from
feat/reauth-and-recovery-test-coverage

Conversation

@demolaf

@demolaf demolaf commented Sep 3, 2026

Copy link
Copy Markdown
Member

Three error recoveries hand the step they navigate to a value the failure carried, and none were covered: AccountLinkingRequiredException writes pendingLinkingCredential, and EmailLinkPromptForEmailException / EmailLinkCrossDeviceLinkingException both write emailLinkFromDifferentDevice. Separately, a custom reauthContent slot is Bare only on MethodPicker — email and phone sub-steps still wrap in the library sheet, and nothing asserted that chrome was present.

  • FirebaseAuthScreenEmailRecoveryTest: 7 cases covering landing step and address for each of the three exceptions, plus the write-through itself — a real linkWithCredential verification for account linking, and isSignInWithEmailLink for both email-link failures.
  • ReauthSurfaceGateTest: 3 cases — the method picker composes bare under a custom slot, and the email and phone steps are asserted to be inside the sheet via ancestry rather than as separate presence checks.

Checked each case against a mutated production branch: dropping the credential write, nulling the prompt's link, swapping the cross-device branch to providerName, and ignoring the step in the reauth gate each fail only their own test.


Maintainer note: Fixes internal CPRN-404

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds comprehensive unit tests to FirebaseAuthScreenEmailRecoveryTest.kt and ReauthSurfaceGateTest.kt. The new tests in FirebaseAuthScreenEmailRecoveryTest.kt verify account recovery flows that pass data (such as credentials or links) to subsequent steps, including account linking, email-link prompts, and cross-device linking. The tests added to ReauthSurfaceGateTest.kt validate the behavior of custom-slot presentation gates, ensuring that the method picker is rendered bare while sub-flows are properly enclosed within the library's sheet. There are no review comments, and I have no feedback to provide.

@demolaf
demolaf marked this pull request as ready for review September 4, 2026 12:36
@demolaf
demolaf force-pushed the feat/reauth-and-recovery-test-coverage branch from 06d3dd4 to 681dc8d Compare September 4, 2026 12:54
@demolaf
demolaf marked this pull request as draft September 4, 2026 12:54
@demolaf
demolaf marked this pull request as ready for review September 4, 2026 12:59
@russellwheatley
russellwheatley merged commit dfab195 into version-10.0.0-beta05 Sep 4, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in studio-2394994192-60a69 Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants