Auth Provider methods with AuthUI parameter #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition to using the default FUIAuth's defaultAuthUI, it would be nice to pass in a custom FUIAuth to create auth provider. |
|
@morganchen12, Would you mind taking a look at this PR? |
There was a problem hiding this comment.
Had one nit, but that can be addressed after merging. Thanks @wimbledon!
|
@morganchen12, fixed the nit. |
morganchen12
approved these changes
Jun 25, 2021
wimbledon
added a commit
to wimbledon/FirebaseUI-iOS
that referenced
this pull request
Aug 5, 2021
When custom FIRAuth is used, it needs to be passed to create AuthProvider. This fix is required for auth providers like Twitter. Related PR: firebase#974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#973