initWithAuthUI: Auth Fix #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When custom FIRAuth is used, it needs to be passed to create AuthProvider. This fix is required for auth providers like Twitter. Related PR: firebase#974
|
@morganchen12 I'm not sure why the two tests are failing. Do you mind taking a look? |
|
Since you changed the selector, the stub on this line is no longer stubbing the correct method. |
|
@morganchen12 Thanks for the comment. |
|
Yep, thanks for the contribution! |
|
@morganchen12, do you mind bumping the SDK version from 12.0.0 to 12.0.1? |
|
I'll take some time to release it today. Apologies for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When custom FIRAuth is used, it needs to be passed to create AuthProvider.
This fix is required for auth providers like Twitter.
Related PR: #974