Skip to content

fix(storage-resize-images): IS_ANIMATED select label is True, the extension says Yes #3123

Description

@cabljac

kits/storage-resize-images/src/config.ts:189 declares the IS_ANIMATED select as select({ True: true, "No (1st frame only)": false }). The extension's extension.yaml:289-292 labels the same option Yes. The kit's param audit tests pin option values only, not labels, which is how this slipped through (tests/config.test.ts).

Fix: change the label to Yes and add an IS_ANIMATED select test that reads the param from declaredParams and asserts both labels and values ([{ label: "Yes", value: true }, { label: "No (1st frame only)", value: false }]).

Split out of #3064 (review thread by @IzaakGough) so that PR stays scoped to the OFF content-filter mapping. A grep across kits/*/src/config.ts finds no other True:/False: select label.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions