docs(kits): remove deprecation markers from kit READMEs - #2936
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes deprecation notices and extension replacement comments from the README files of various Firebase extension kits, including firestore-bigquery-export, firestore-counter, firestore-genai-chatbot, firestore-incremental-capture, firestore-send-email, firestore-translate-text, rtdb-limit-child-nodes, and speech-to-text. I have no feedback to provide as there are no review comments and the changes are straightforward documentation updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the machine-readable deprecation markers and notices added in #2934.
Per Andy's feedback, the marker must live in the extension source README (the repo you reach from the extension page's "source code" link), so that someone with write access to the extension source is provably designating the replacement kit. A marker in the kit README does not prove ownership, since anyone could publish a kit in an unrelated repo.
Extension-side markers are added in #2935 (targeting
kits).