Skip to content

Add priming logic to integration tests to avoid backend cold start issues. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 3, 2018
Merged

Add priming logic to integration tests to avoid backend cold start issues. #50

merged 6 commits into from
Oct 3, 2018

Conversation

@mikelehen
Copy link
Contributor

@mikelehen mikelehen commented Sep 28, 2018 •
edited
Loading

Port of firebase/firebase-js-sdk#1259 with the additional changes:

  1. I'm reducing and unifying our existing timeouts. We had a 30s per operation timeout, an unused 120s timeout for parallel operations, and a 10s "shutdown" timeout. I'm creating a single operation timeout at 10s (which is still fairly generous I think).
  2. I didn't use EventAccumulator since it hits the default timeout. I just manually do the listener.

@mikelehen mikelehen requested a review from wilhuff September 28, 2018 00:35
@mikelehen
Copy link
Contributor Author

mikelehen commented Sep 28, 2018

/retest

1 similar comment
@ashwinraghav
Copy link
Contributor

ashwinraghav commented Sep 28, 2018

/retest

@ashwinraghav ashwinraghav mentioned this pull request Sep 28, 2018
Merged
@mikelehen
Copy link
Contributor Author

mikelehen commented Sep 28, 2018

/retest

2 similar comments
@mikelehen
Copy link
Contributor Author

mikelehen commented Sep 28, 2018

/retest

@mikelehen
Copy link
Contributor Author

mikelehen commented Sep 28, 2018

/retest

@mikelehen mikelehen force-pushed the mikelehen/prime-backend branch from 9e4c42b to 342eaf2 Compare September 28, 2018 22:35
@mikelehen mikelehen mentioned this pull request Sep 28, 2018
Closed
@mikelehen
Copy link
Contributor Author

mikelehen commented Oct 1, 2018

/retest

@mikelehen
Copy link
Contributor Author

mikelehen commented Oct 2, 2018

@wilhuff CI is functional again and this PR is green. PTAL

wilhuff
wilhuff approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned mikelehen and unassigned wilhuff Oct 3, 2018
@mikelehen mikelehen merged commit 7820ad7 into master Oct 3, 2018
@mikelehen mikelehen deleted the mikelehen/prime-backend branch October 3, 2018 17:18
@mikelehen mikelehen restored the mikelehen/prime-backend branch October 23, 2018 22:38
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wilhuff wilhuff wilhuff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikelehen mikelehen

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikelehen @ashwinraghav @wilhuff @google-oss-bot