Skip to content

automate version validation with prod test suite#8015

Merged
MaesterChestnut merged 10 commits into
mainfrom
fadAutomatedProTests
May 20, 2026
Merged

automate version validation with prod test suite#8015
MaesterChestnut merged 10 commits into
mainfrom
fadAutomatedProTests

Conversation

@MaesterChestnut
Copy link
Copy Markdown
Contributor

No description provided.

@MaesterChestnut MaesterChestnut requested a review from kaibolay April 6, 2026 11:53
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

kaibolay
kaibolay previously approved these changes Apr 6, 2026
Comment thread firebase-appdistribution-gradle/firebase-appdistribution-gradle.gradle Outdated
@kaibolay
Copy link
Copy Markdown
Contributor

kaibolay commented May 8, 2026

Right now we test with the oldest supported stable versions of Gradle, AGP, and GoogleServices and the most recent (non-alpha, non-snapshot) version of all three (Note: As far as I know, GoogleServices doesn't publish any snapshot, alpha, or RC versions):

Gradle AGP GoogleServices
oldest supported oldest supported oldest supported
latest (incl. rc) latest (incl. rc) latest

Maybe we should (also?) test with the latest stable versions of all three? Maybe other combinations also make sense (e.g. "bleeding edge")?

Gradle AGP GoogleServices
oldest supported oldest supported oldest supported
latest stable latest stable latest stable
latest (incl. rc) latest (incl. rc) latest stable
latest (incl. snapshot) latest (incl. alpha) latest stable

Maybe the additional combinations can be tested automagically each time the tests run - or they can be selected via flags (e.g. --versions=(oldest|stable|rc|bleeding-edge)) or parameters?

@kaibolay kaibolay requested a review from rebehe May 8, 2026 16:22
rebehe
rebehe previously approved these changes May 8, 2026
@rebehe
Copy link
Copy Markdown
Contributor

rebehe commented May 8, 2026

Right now we test with the oldest supported stable versions of Gradle, AGP, and GoogleServices and the most recent (non-alpha, non-snapshot) version of all three (Note: As far as I know, GoogleServices doesn't publish any snapshot, alpha, or RC versions):

Gradle AGP GoogleServices
oldest supported oldest supported oldest supported
latest (incl. rc) latest (incl. rc) latest
Maybe we should (also?) test with the latest stable versions of all three? Maybe other combinations also make sense (e.g. "bleeding edge")?

Gradle AGP GoogleServices
oldest supported oldest supported oldest supported
latest stable latest stable latest stable
latest (incl. rc) latest (incl. rc) latest stable
latest (incl. snapshot) latest (incl. alpha) latest stable
Maybe the additional combinations can be tested automagically each time the tests run - or they can be selected via flags (e.g. --versions=(oldest|stable|rc|bleeding-edge)) or parameters?

VersionUtils does test with the latest stable version - is that sufficient?

@MaesterChestnut MaesterChestnut dismissed stale reviews from rebehe and kaibolay via f1f8649 May 19, 2026 17:21
@MaesterChestnut MaesterChestnut force-pushed the fadAutomatedProTests branch 2 times, most recently from eb856b2 to 048da68 Compare May 19, 2026 19:53
kaibolay
kaibolay previously approved these changes May 19, 2026
rebehe
rebehe previously approved these changes May 19, 2026
Copy link
Copy Markdown
Contributor

@rebehe rebehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MaesterChestnut MaesterChestnut dismissed stale reviews from rebehe and kaibolay via 6ea8862 May 19, 2026 20:50
@MaesterChestnut MaesterChestnut requested a review from rebehe May 19, 2026 22:44
@MaesterChestnut MaesterChestnut merged commit d822416 into main May 20, 2026
180 of 182 checks passed
@MaesterChestnut MaesterChestnut deleted the fadAutomatedProTests branch May 20, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants