Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the calculation of debug logging strings by introducing a new DeserializeUtils utility and cleaning up ProtoUtil. The changes involve moving error deserialization logic and streamlining the construction of protobuf structs for responses. Feedback includes a suggestion to simplify a when block in DeserializeUtils using toCompactString() for better consistency and a recommendation to remove an unused putValue method in ProtoUtil.
This PR refactors data connect's internal logic for calculating debug logging strings, specifically focusing on the conversion of protobuf messages to compact string representations.
Highlights
DeserializeUtilsutility class to centralize the conversion of protobufGraphqlErrorandListValueobjects into internal data structures.ProtoUtil.toStructProto()to leverageDeserializeUtils.StructProtoBuilderwith new helper methods for handlingGraphqlResponseExtensionsandGraphqlErrorcollections.Changelog
3 files changed
toStructProtoand updatedStructProtoBuilderwith more efficient data handling methods.