Add Gemini 3.5 flash models to testing#8213
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for Gemini 3.5 Flash models to the AIModels class for Android integration tests, introducing vertexAI3_5FlashModel and googleAI3_5FlashModel. The review feedback highlights two main issues: first, Vertex AI is a regional service and does not support a "global" location, so using "global" will cause runtime errors; second, the newly introduced variable names violate the Kotlin Style Guide because they contain underscores and should be renamed to standard camelCase (e.g., vertexAI35FlashModel and googleAI35FlashModel).
|
The amount of different possible variables is starting to reach the point where we need to consider alternatives. Let's move forward but start looking at alternatives |
Gemini 3.5 was recently released and passes existing testing, should be tested for the future.