Skip to content

docs(auth): fix typo in User::GetToken docstring - #1895

Merged
AustinBenoit merged 1 commit into
mainfrom
java-fix
Jul 29, 2026
Merged

docs(auth): fix typo in User::GetToken docstring #1895
AustinBenoit merged 1 commit into
mainfrom
java-fix

Conversation

@AustinBenoit

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Java Web Token -> JSON Web Token


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

String change only.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AustinBenoit
AustinBenoit requested a review from a-maurice July 29, 2026 17:45

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the documentation of the User class in user.h, changing 'Java Web Token' to 'JSON Web Token' (JWT). There are no review comments, and I have no additional feedback to provide.

@AustinBenoit AustinBenoit added the skip-release-notes Skip release notes check label Jul 29, 2026
@AustinBenoit
AustinBenoit merged commit a3998aa into main Jul 29, 2026
43 of 55 checks passed
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @AustinBenoit on commit a3998aa
Last updated: Wed Jul 29 15:00 PDT 2026
View integration test log & download artifacts

Failures Configs
auth [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_ftl_target]
database [TEST] [ERROR] [Android] [2/3 os: windows ubuntu] [1/2 android_device: emulator_ftl_target]
firestore [TEST] [ERROR] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [ERROR] [Android] [2/3 os: windows ubuntu] [1/2 android_device: emulator_ftl_target]
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
storage [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_ftl_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Jul 29, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants