Skip to content

Reduce Auth flake on MacOS #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Reduce Auth flake on MacOS #78

wants to merge 2 commits into from

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 9, 2020 •
edited
Loading

  • Updated test utils for auth state change and token change listener verification.
    • Added a overarching timeout value . The verifiers will tick to check the results until the timeout is reached.
    • Only APPLE platforms use the timeout values. Other platforms (Linux, Windows, Android) continue to have direct verification flows without waiting for callbacks to be invoked.

@DellaBitta DellaBitta changed the title added a grace period of 10s for macos listener verification in unit t… Remove Auth flake on MacOS from orbit Jul 9, 2020
@DellaBitta DellaBitta changed the title Remove Auth flake on MacOS from orbit Reduce Auth flake on MacOS Jul 9, 2020
@DellaBitta DellaBitta requested a review from vimanyu July 9, 2020 20:40
@DellaBitta DellaBitta marked this pull request as ready for review July 9, 2020 20:41
@DellaBitta DellaBitta closed this Jul 12, 2020
@DellaBitta DellaBitta deleted the feature/gha-listener-timeout branch July 20, 2020 14:12
@firebase firebase locked and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vimanyu vimanyu Awaiting requested review from vimanyu

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DellaBitta @googlebot