Skip to content

Reduce Auth flake on MacOS #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Reduce Auth flake on MacOS #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd4f178
added a grace period of 10s for macos listener verification in unit t…
DellaBitta Jul 9, 2020
8fc3864
output sleep progression
DellaBitta Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions auth/tests/desktop/test_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,29 @@ void ListenerChangeCounter::ExpectChanges(const int num) {
expected_changes_ = num;
}
void ListenerChangeCounter::VerifyAndReset() {
Verify();
int timeout_value = -1;
#ifdef __APPLE__
timeout_value = 10000;
#endif
Verify(timeout_value);
expected_changes_ = -1;
actual_changes_ = 0;
}

void ListenerChangeCounter::Verify() {
void ListenerChangeCounter::Verify(int timeout) {
if (expected_changes_ != -1) {
if (timeout >= 0 && expected_changes_ != actual_changes_) {
int elapsed_time = 0;
while( elapsed_time <= timeout ) {
printf(".");
firebase::internal::Sleep(100);
elapsed_time += 100; // only estimating elapsed time to simplfy portability.
if(expected_changes_ == actual_changes_) {
break;
}
}
printf("\n");
}
EXPECT_EQ(expected_changes_, actual_changes_);
}
}
Expand Down
4 changes: 2 additions & 2 deletions auth/tests/desktop/test_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ class ListenerChangeCounter {
int actual_changes_;

private:
void Verify();
void Verify(int timeout = -1);

int expected_changes_;
volatile int expected_changes_;
};
} // namespace detail

Expand Down