Skip to content

Remove gnustl support and update NDK #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 3, 2022
Merged

Remove gnustl support and update NDK #889

merged 14 commits into from
May 3, 2022

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 11, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

For next major revision, remove gnustl support and update to NDK r21e.

In the SDK binary distribution, Android libraries are now in simply libs/android/ARCH, with no STL path component.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running integration tests in the PR.
Running c++ packaging workflow on the branch and confirming Android libraries are placed in the correct location.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 11, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 11, 2022
@github-actions
Copy link

github-actions bot commented Apr 11, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 65e16b5
Last updated: Tue May 3 12:42 PDT 2022
View integration test log & download artifacts

Failures Configs
database [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseDatabaseTest.TestInfoConnected
firestore [TEST] [FAILURE] [Linux] [openssl]
(1 failed tests)  ValidationTest.QueriesCannotBeSortedByAnUncommittedServerTimestamp
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  QueryTest.TestFilterOnInfinity
storage [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 11, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 11, 2022
@jonsimantov jonsimantov marked this pull request as ready for review April 12, 2022 18:13
@jonsimantov jonsimantov requested review from a-maurice and removed request for a-maurice April 12, 2022 18:13
@jonsimantov jonsimantov marked this pull request as draft April 12, 2022 18:14
@jonsimantov jonsimantov self-assigned this Apr 12, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 20, 2022
@jonsimantov jonsimantov removed the tests-requested: quick Trigger a quick set of integration tests. label Apr 20, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Apr 20, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 20, 2022
@jonsimantov jonsimantov marked this pull request as ready for review April 21, 2022 18:20
@jonsimantov jonsimantov requested a review from a-maurice April 23, 2022 00:58
@dconeybe dconeybe mentioned this pull request Apr 26, 2022
Closed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 26, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 26, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 26, 2022
dconeybe
dconeybe reviewed Apr 29, 2022
View reviewed changes
a-maurice
a-maurice reviewed May 2, 2022
View reviewed changes
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels May 2, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 2, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@jonsimantov jonsimantov requested a review from a-maurice May 3, 2022 07:23
a-maurice
a-maurice approved these changes May 3, 2022
View reviewed changes
@jonsimantov jonsimantov merged commit 65e16b5 into main May 3, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@firebase firebase locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe left review comments

@a-maurice a-maurice a-maurice approved these changes

Assignees

@jonsimantov jonsimantov

@a-maurice a-maurice

Labels

tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonsimantov @a-maurice @dconeybe