Create individual Python virtualenv's in cmake builds #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @dconeybe on commit 79b91ca
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
…ause 3.10.2 is not supported on windows-latest GitHub runners
…0.2) because 3.10.2 is not supported on windows-latest GitHub runners" This reverts commit e21af90. Using cmake 3.18.1 from the Android NDK suffered from the bug where the build failed with "Invalid revision: 3.18.1-g262b901". This is a known android studio bug that, for some reason, has never been fixed.
This reverts commit 2836f21. Cmake 3.10.2 is not installed on the windows-latest GitHub Actions runner image.
…n the android sdk
…ith debugging build issues
… arguments in build.gradle files
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Contributor
Author
|
The last of the build errors are related to gradle communicating with cmake. I think those will be fixed once we upgrade the gradle plugin, which will happen after dropping gnustl support (#889). I'm going to put this PR on hold for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a Python virtualenv when running Python scripts during a cmake build.
This PR is a copy of firebase/firebase-ios-sdk#9662.
This PR adds a new cmake module,
python_setup, that defines a single function:FirebaseSetupPythonInterpreter(). This function will find a Python interpreter installed on the system, create a virtualenv with it, pip-install dependencies into it, and set a variable to the path of the Python executable. Then, when cmake wants to run a Python script, it uses the one in the virtualenv.This has several benefits compared to the old design: