Skip to content

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 2, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Update macos runners to use macos-12 (public beta) instead of macos-latest (equivalent to macos-11).

This change requires updating to Xcode 13.1 as a stopgap solution; we will update to Xcode 13.2.1 or Xcode 13.3.1 in a subsequently-merged PR. Updating to Xcode 13 necessitates updating iOS simulator versions as well.

Note: skipping release notes check, because the subsequent PR (#915) updates the release notes with the new Xcode version requirement.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration test run in the PR.
C++ packaging step here: https://github.com/firebase/firebase-cpp-sdk/actions/runs/2260453371


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

✅  Integration test succeeded!

Requested by @jonsimantov on commit 25da83c
Last updated: Tue May 3 13:28 PDT 2022
View integration test log & download artifacts

@dconeybe
Copy link
Contributor

dconeybe commented May 2, 2022

FYI The Xcode upgrade could experience build errors if compiling against the iOS SDK that does not have an Xcode 13.3.1 fix (firebase/firebase-ios-sdk#9705).

@jonsimantov
Copy link
Contributor Author

FYI The Xcode upgrade could experience build errors if compiling against the iOS SDK that does not have an Xcode 13.3.1 fix (firebase/firebase-ios-sdk#9705).

Thanks. I'll be trying this in the 9.0.0 branch as well.

@jonsimantov jonsimantov changed the title Change xcode version to 13.3.1 and macos runners to macos-12. Change macos runners to macos-12. (requires updating xcode to 13.1) May 2, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@jonsimantov jonsimantov added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels May 2, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@jonsimantov jonsimantov marked this pull request as ready for review May 2, 2022 21:42
@jonsimantov jonsimantov requested a review from sunmou99 May 2, 2022 21:42
@sunmou99
Copy link
Contributor

sunmou99 commented May 2, 2022

Updated the macos runner name with a matrix variable.
Testing workflow: https://github.com/firebase/firebase-cpp-sdk/actions/runs/2260685352

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@jonsimantov
Copy link
Contributor Author

Updated the macos runner name with a matrix variable. Testing workflow: https://github.com/firebase/firebase-cpp-sdk/actions/runs/2260685352

Nice, thanks! I just kicked off a new tests-requested on this PR so you can cancel your separate test run if you want.

@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 2, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 2, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 3, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 3, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 3, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 3, 2022
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels May 3, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) May 3, 2022 17:18
@jonsimantov jonsimantov merged commit 25da83c into main May 3, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 3, 2022
@jonsimantov jonsimantov deleted the update-runners-macos-12 branch May 3, 2022 18:07
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 3, 2022
@firebase firebase locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants